Project

General

Custom queries

Profile

Actions
Copy link

Bug #17951

closed

Installation fails/breaks when there is a double dash (--) in the domainname of a machine.

Added by Jan Vansteenkiste over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Settings
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4158
Fixed in Releases:
Found in Releases:
1.13.3
Red Hat JIRA:

Description

The rake tasks (db:seed) throws a terrible stacktrace with a validation error. After a lot of debugging I narrowed it down to:

Given domainname: foo--bar.example.com

In app/models/setting/general.rb#L8

    administrator = "root@#{domain}"

Which is validated by app/validators/email_validator.rb and fails.

Possible solutions are backporting the changes to the email_validator (using the mail gem) or adjusting the beast of a regex to match domain names with double dashes in the name.

#2

Updated by Dominic Cleal over 8 years ago

  • Category set to Settings
  • Priority changed from Urgent to Normal
#3

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4158 added
#4

Updated by Amir Fefer almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF