Project

General

Profile

Actions

Bug #1811

closed

Parameter issue with foreman::puppetmaster

Added by Peter Bauer over 12 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
easy
Triaged:
Fixed in Releases:
Found in Releases:

Description

In the puppet-puppet module (manifests/server/config.pp:6) the foreman::puppetmaster class is included. The foreman::puppetmaster class and the foreman::config::enc class that is included (and the used templates) are therefore only able to use the default values hardcoded in foreman::params, not the parameters given to the foreman class. This leads to problems when using the foreman class e.g. with parameter foreman_url: The ENC and reporting config files will contain a different Foreman URL than given to the foreman class.
I suggest to include the foreman::puppetmaster class in foreman::config with a notify => Class['puppet::server::service'] and not use foreman::params:: values but foreman:: parameters instead.

Actions #1

Updated by Ohad Levy over 12 years ago

great, would you mind sending a patch / github pull request?

thanks!

Actions #2

Updated by Peter Bauer over 12 years ago

will do ASAP

Actions #3

Updated by Peter Bauer almost 12 years ago

Obsolete due to commit:ed7c8f63dfa3351d65956ab6cf4569e17586f91f

Actions #4

Updated by Ewoud Kohl van Wijngaarden about 11 years ago

  • Description updated (diff)
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Since this has been fixed a long time ago, let's close this :).

Actions

Also available in: Atom PDF