Project

General

Profile

Bug #1873

Too tight limit on domain characters count

Added by Jaroslav Henner almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Category:
DB migrations
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

We have awfully long domain names. Foreman seems to not like it either

 x PG::Error: ERROR: value too long for type character varying(32) : INSERT INTO "domains" ("created_at", "name", "updated_at", "dns_id", "fullname") VALUES ('2012-09-25 06:44:44.616460', 'beryllium.xxx.xxx.xxx.xxx.redhat.com', '2012-09-25 06:44:44.616460', 1, 'beryllium.xxx.xxx.xxx.xxx.redhat.com') RETURNING "id" 

I already seen some issues of this sort with another DB column. I would vote to review the limits. Or should 32 characters be enough for everybody?

Associated revisions

Revision cb707306 (diff)
Added by Hannes Schaller almost 10 years ago

fixes #1873 changed domain character count to 254 chars

History

#1 Updated by Greg Sutcliffe almost 10 years ago

I think it's an reasonable request - Ohad, do you agree?

#2 Updated by Ohad Levy almost 10 years ago

  • Priority changed from High to Normal

+1

#3 Updated by Hannes Schaller almost 10 years ago

According to wikipedia:

Each label may contain up to 63 characters. The full domain name may not exceed a total length of 253 characters in its external dotted-label specification. In the internal binary representation of the DNS the maximum length requires 255 octets of storage.

( http://en.wikipedia.org/wiki/Domain_Name_System#Domain_name_syntax )

So I think changing it to 253 characters should fix it.

#4 Updated by Ohad Levy almost 10 years ago

  • Category set to DB migrations
  • Assignee set to Hannes Schaller
  • Target version set to 1.1

#5 Updated by Hannes Schaller almost 10 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF