Bug #1873
closedToo tight limit on domain characters count
Description
We have awfully long domain names. Foreman seems to not like it either
x PG::Error: ERROR: value too long for type character varying(32) : INSERT INTO "domains" ("created_at", "name", "updated_at", "dns_id", "fullname") VALUES ('2012-09-25 06:44:44.616460', 'beryllium.xxx.xxx.xxx.xxx.redhat.com', '2012-09-25 06:44:44.616460', 1, 'beryllium.xxx.xxx.xxx.xxx.redhat.com') RETURNING "id"
I already seen some issues of this sort with another DB column. I would vote to review the limits. Or should 32 characters be enough for everybody?
Updated by Greg Sutcliffe about 12 years ago
I think it's an reasonable request - Ohad, do you agree?
Updated by Hannes Schaller about 12 years ago
According to wikipedia:
Each label may contain up to 63 characters. The full domain name may not exceed a total length of 253 characters in its external dotted-label specification. In the internal binary representation of the DNS the maximum length requires 255 octets of storage.
( http://en.wikipedia.org/wiki/Domain_Name_System#Domain_name_syntax )
So I think changing it to 253 characters should fix it.
Updated by Ohad Levy about 12 years ago
- Category set to DB migrations
- Assignee set to Hannes Schaller
- Target version set to 1.1
Updated by Hannes Schaller about 12 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset cb7073067d7b647e0a1eb18afaf5811b3ea739b3.