Bug #1873: Too tight limit on domain characters count - Foreman

Actions

Copy link

Bug #1873

closed

Too tight limit on domain characters count

Added by Jaroslav Henner over 11 years ago. Updated over 11 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Hannes Schaller

Category:

DB migrations

Target version:

1.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

We have awfully long domain names. Foreman seems to not like it either

 x PG::Error: ERROR: value too long for type character varying(32) : INSERT INTO "domains" ("created_at", "name", "updated_at", "dns_id", "fullname") VALUES ('2012-09-25 06:44:44.616460', 'beryllium.xxx.xxx.xxx.xxx.redhat.com', '2012-09-25 06:44:44.616460', 1, 'beryllium.xxx.xxx.xxx.xxx.redhat.com') RETURNING "id"

I already seen some issues of this sort with another DB column. I would vote to review the limits. Or should 32 characters be enough for everybody?

Actions

Copy link

Updated by Greg Sutcliffe over 11 years ago

I think it's an reasonable request - Ohad, do you agree?

Actions

Copy link

Updated by Ohad Levy over 11 years ago

Priority changed from High to Normal

Actions

Copy link

Updated by Hannes Schaller over 11 years ago

According to wikipedia:

Each label may contain up to 63 characters. The full domain name may not exceed a total length of 253 characters in its external dotted-label specification. In the internal binary representation of the DNS the maximum length requires 255 octets of storage.

( http://en.wikipedia.org/wiki/Domain_Name_System#Domain_name_syntax )

So I think changing it to 253 characters should fix it.

Actions

Copy link