Project

General

Custom queries

Profile

Actions
Copy link

Refactor #19699

closed

Remove unnecessary monkey patching

Added by Shimon Shtein almost 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shimon Shtein
Category:
-
Target version:
foreman-tasks-0.10.4
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-tasks/pull/251, https://github.com/theforeman/foreman-tasks/pull/288
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

In host_action_subject.rb, there is monkey patching of import_host method.
It is not necessary and will cause problems once fact import process is changed.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Refactor #15409: Refactor (puppet) facts out of host classes.ClosedShimon ShteinActions

Added by Shimon Shtein over 7 years ago

Revision bdd395f9 (diff)

Fixes #19699 - Removed import_host monkey patch

Once https://github.com/theforeman/foreman/pull/3649 gets in core,
there will be no need for monkey patch.
In addition, it handles changes in `#import_host` signature.

Added by Shimon Shtein over 7 years ago

Revision 3768075c (diff)

Refs #19699 - Fixed older method signature

Actions
Copy link

Also available in: Atom PDF