Project

General

Profile

Actions

Bug #20710

closed

View diff modal window overflows

Added by Marek Hulán about 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Reporting
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

While verifying #2816 I realized we have the overflow issue again. For some reason we hardcode the value in JS which seems to be prone to regression. I'll open the PR with the same fix we took last time but I'll be happy to hear from front-end experts how to solve it better.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #2816: diff view brokenResolved07/22/2013Actions
Actions #1

Updated by Marek Hulán about 7 years ago

  • Related to Bug #2816: diff view broken added
Actions #2

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4779 added
Actions #3

Updated by Marek Hulán about 7 years ago

  • Target version changed from 1.18.0-RC2 to 214
Actions #4

Updated by Tomer Brisker about 7 years ago

  • Translation missing: en.field_release set to 240
Actions #5

Updated by Marek Hulán about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF