Project

General

Profile

Bug #20710

View diff modal window overflows

Added by Marek Hulán 11 months ago. Updated 10 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Reporting
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

While verifying #2816 I realized we have the overflow issue again. For some reason we hardcode the value in JS which seems to be prone to regression. I'll open the PR with the same fix we took last time but I'll be happy to hear from front-end experts how to solve it better.


Related issues

Related to Foreman - Bug #2816: diff view brokenResolved2013-07-22

Associated revisions

Revision 3664d8fd (diff)
Added by Marek Hulán 11 months ago

Fixes #20710 - fix view diff width

Revision a3c1dc2f (diff)
Added by Marek Hulán 10 months ago

Fixes #20710 - fix view diff width

(cherry picked from commit 3664d8fd29cc5ebdaad302e171bd7f26c3f68046)

History

#1 Updated by Marek Hulán 11 months ago

  • Related to Bug #2816: diff view broken added

#2 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4779 added

#3 Updated by Marek Hulán 11 months ago

  • Target version changed from 1.18.0-RC2 to 214

#4 Updated by Tomer Brisker 11 months ago

  • Legacy Backlogs Release (now unused) set to 240

#5 Updated by Marek Hulán 11 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF