Refactor #21920: Refactor password auditing - Foreman

Refactor #21920

Refactor password auditing

Added by Michael Moll over 1 year ago. Updated 9 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomer Brisker

Category:

Rails

Target version:

1.18.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/5162

Team Backlog:

Fixed in Releases:

Found in Releases:

Description

Starting with Rails 5.1:

- message: password_changed is not an attribute known to Active Record. This behavior
    is deprecated and will be removed in the next version of Rails. If you'd like
    password_changed to be managed by Active Record, add `attribute :password_changed
    to your class.
  callstack: app/models/image.rb:31:in `set_password_changed'
- message: password_changed is not an attribute known to Active Record. This behavior
    is deprecated and will be removed in the next version of Rails. If you'd like
    password_changed to be managed by Active Record, add `attribute :password_changed
    to your class.
  callstack: app/models/user.rb:527:in `set_password_changed'

Related issues

Associated revisions

Revision 59f0a945 (diff)
Added by Tomer Brisker over 1 year ago

Fixes #22208, #21920 - Refactor password auditing (#5162)

Recent changes in Rails 5.1 and audited gem cause our method of auditing
passwords to break. This PR refactors password auditing, so that instead
of recording a change to attribute `password_changed`, we will now
record the string `[redacted]` instead of any actual password.
The change is done currently in our audit extensions, which mean that it
will now apply to all resources that have a `password` attribute instead
of just those that have defined the workaround.
The next step will be to move this to the audited gem in a more
generalized method that can be defined in the model when initializing
audited, so that the workaround can be removed.