Project

General

Profile

Bug #22801

Spice connection with websockets encryption

Added by Rafał Ramocki over 3 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Compute resources
Target version:

Description

When websockets_encryption is set to true on foreman 1.16 spice doesn't work because JavaScript ./app/assets/javascripts/spice.js (line 5) have hardcoded schema "ws://" that in this case should be "wss://". Websockets encryption is required to have spice working on Chrome (version 64.0.3282.140) without additional configuration as it by default refuses to connect to websockets without encryption and truted certificate. File is unchanged in current head.

Associated revisions

Revision 10d5e55c (diff)
Added by Ewoud Kohl van Wijngaarden 2 months ago

Fixes #22801 - Encrypted spice consoles

While WsProxy already encrypted the connection, the UI was hardcoded to
ws://. With this patch it respects the websockets_encrypt setting and
uses wss:// if needed.

History

#1 Updated by Rafał Ramocki over 3 years ago

  • Subject changed from Spice connection websockets encryption to Spice connection with websockets encryption

#3 Updated by Tomer Brisker over 2 years ago

  • Category set to Compute resources

#4 Updated by The Foreman Bot 6 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8515 added

#5 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Triaged changed from No to Yes
  • Found in Releases 1.2.0 added

#6 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8698 added

#7 Updated by The Foreman Bot 2 months ago

  • Fixed in Releases 3.1.0 added

#8 Updated by Ewoud Kohl van Wijngaarden 2 months ago

  • Target version set to 3.0.0

Merged for 3.1.0 but I think it can be picked to 3.0.0. Setting target version so we don't forget.

#9 Updated by Ewoud Kohl van Wijngaarden 2 months ago

  • Status changed from Ready For Testing to Closed

#10 Updated by The Foreman Bot 2 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8717 added

#11 Updated by Tomer Brisker 2 months ago

  • Fixed in Releases 3.0.0 added
  • Fixed in Releases deleted (3.1.0)

Also available in: Atom PDF