Bug #25148: productDelete function not called on product delete - Katello - Foreman

Actions

Copy link

Bug #25148

closed

productDelete function not called on product delete

Added by Michael Johnson almost 6 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Andrew Kofink

Category:

Web UI

Target version:

Katello 3.9.0

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/7772

Fixed in Releases:

Found in Releases:

Katello 3.4.0, Katello 3.4.1, Katello 3.4.2, Katello 3.4.3, Katello 3.4.4, Katello 3.4.5, Katello 3.4.6, Katello 3.5.0, Katello 3.5.1, Katello 3.5.2, Katello 3.5.3, Katello 3.6.0, Katello 3.6.1, Katello 3.7.0, Katello 3.7.1, Katello 3.8.1, Katello 3.8.2, Katello 3.9.0, Katello 3.9.1

Red Hat JIRA:

Description

When deleting a product from within the product details page (use "Select Action" drop down and choose "Remove Product" after you have clicked into the product) the notification message informing you that the foreman task to delete the product has been started does not populate. In fact, the function isn't called at all and I know for a fact that the "event" variable is undefined before it hits the function.

https://github.com/Katello/katello/blob/44ab18ee50f0b0b92ec498d5b5bb34d4f508fcab/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/products.controller.js#L62

Be aware that the function may need some changing to properly pass the link into the Notification.setSuccessMessage function call.

This bug was found while fixing this issue: https://projects.theforeman.org/issues/25047

Bastion fix can be found here: https://github.com/Katello/bastion/pull/233 - you'll need this to know what to pass into Notification.setSuccessMessage

Katello fix can be found here: https://github.com/Katello/katello/pull/7743

Actions

Copy link

Updated by Justin Sherrill almost 6 years ago

Priority changed from Normal to High
Triaged changed from No to Yes

Actions

Copy link

Updated by Andrew Kofink almost 6 years ago

Assignee changed from Michael Johnson to Andrew Kofink

Actions

Copy link

Updated by Andrew Kofink almost 6 years ago

This is not a 3.9 regression. It also happens as far back as 3.4

Actions

Copy link

Updated by Andrew Kofink almost 6 years ago

Priority changed from High to Normal

I don't see how this is a high priority issue, considering it's been broken for so long. If others disagree, feel free to change it back with some justification.

Actions

Copy link

Updated by Andrew Kofink almost 6 years ago

Found in Releases Katello 3.4.0, Katello 3.4.1, Katello 3.4.2, Katello 3.4.3, Katello 3.4.4, Katello 3.4.5, Katello 3.4.6, Katello 3.5.0, Katello 3.5.1, Katello 3.5.2, Katello 3.5.3, Katello 3.6.0, Katello 3.6.1, Katello 3.7.0, Katello 3.7.1, Katello 3.8.1, Katello 3.8.2, Katello 3.9.0, Katello 3.9.1 added

Actions

Copy link