Project

General

Custom queries

Profile

Actions

Bug #25148

closed

productDelete function not called on product delete

Added by Michael Johnson over 6 years ago. Updated over 6 years ago.


Description

When deleting a product from within the product details page (use "Select Action" drop down and choose "Remove Product" after you have clicked into the product) the notification message informing you that the foreman task to delete the product has been started does not populate. In fact, the function isn't called at all and I know for a fact that the "event" variable is undefined before it hits the function.

https://github.com/Katello/katello/blob/44ab18ee50f0b0b92ec498d5b5bb34d4f508fcab/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/products.controller.js#L62

Be aware that the function may need some changing to properly pass the link into the Notification.setSuccessMessage function call.

This bug was found while fixing this issue: https://projects.theforeman.org/issues/25047

Bastion fix can be found here: https://github.com/Katello/bastion/pull/233 - you'll need this to know what to pass into Notification.setSuccessMessage

Katello fix can be found here: https://github.com/Katello/katello/pull/7743

#1

Updated by Justin Sherrill over 6 years ago

  • Priority changed from Normal to High
  • Triaged changed from No to Yes
#2

Updated by Andrew Kofink over 6 years ago

  • Assignee changed from Michael Johnson to Andrew Kofink
#4

Updated by Andrew Kofink over 6 years ago

  • Priority changed from High to Normal
#5

Updated by Andrew Kofink over 6 years ago

  • Found in Releases Katello 3.4.0, Katello 3.4.1, Katello 3.4.2, Katello 3.4.3, Katello 3.4.4, Katello 3.4.5, Katello 3.4.6, Katello 3.5.0, Katello 3.5.1, Katello 3.5.2, Katello 3.5.3, Katello 3.6.0, Katello 3.6.1, Katello 3.7.0, Katello 3.7.1, Katello 3.8.1, Katello 3.8.2, Katello 3.9.0, Katello 3.9.1 added
#6

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7772 added
#7

Updated by Andrew Kofink over 6 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF