Project

General

Profile

Actions
Copy link

Refactor #25605

closed

drop hypervisor_guest_uuids from SubscriptionFacet

Added by Evgeni Golov about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Evgeni Golov
Category:
-
Target version:
Katello 3.11.0
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/7861
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

currently, SubscriptionFacet.hypervisor_guest_uuids is never set, as the assignment is conditional on an non-existing key:

       def update_from_consumer_attributes(consumer_params)
         import_database_attributes(consumer_params)
         self.hypervisor_guest_uuids = consumer_params['guestIds'] unless consumer_params['hypervisor_guest_uuids'].blank?
         self.facts = consumer_params['facts'] unless consumer_params['facts'].blank?
       end

And if you change that to the correct key:

self.hypervisor_guest_uuids = consumer_params['guestIds'] unless consumer_params['guestIds'].blank?

you end up with an error:
NoMethodError: undefined method `hypervisor_guest_uuids=' for #<Katello::Host::SubscriptionFacet:0x000055d632ba3b60>

As such, I think hypervisor_guest_uuids is unused and can be removed.

Actions
Copy link
 #1

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7861 added
Actions
Copy link
 #2

Updated by Andrew Kofink about 6 years ago

  • Target version set to Katello 3.11.0
  • Triaged changed from No to Yes
Actions
Copy link
 #3

Updated by Evgeni Golov about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF