Project

General

Custom queries

Profile

Actions
Copy link

Bug #26367

closed

Building a tarball with Rakefile.dist fails over $CHILD_STATUS

Added by Ewoud Kohl van Wijngaarden about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Development tools
Target version:
1.22.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6576
Fixed in Releases:
1.22.0
Found in Releases:
1.22.0
Red Hat JIRA:

Description

When invoking rake -f Rakefile.dist pkg:generate_source it fails because the English module is not required. Using $? does work.

Added by Ewoud Kohl van Wijngaarden about 6 years ago

Revision 13503354 (diff)

Fixes #26367 - Fix building sources outside of bundler

Using `rake -f Rakefile.dist pkg:generate_source` fails because it
doesn't require the English module. This means $CHILD_STATUS is not set
and the task fails. When using it via Rakefile it loads the main
application which pulls in the English module somewhere so there the
issue doesn't exist.

By requiring English we ensure the readable version is present.

Actions
Copy link

Also available in: Atom PDF