Foreman » Smart Proxy

I'm using the Debian nightly builds. Currently 9999+debian1~nightlybuild1370929161

I can replicate this if there's no production environment specified - obviously if you have a modulepath for both [master] and [production] it just adds master to the environment list. I assume we want to make some kind of hardcoded mapping that if there is only master, it should be named production?

Puppet documentation says that [main], [master], [agent], and [user] are forbidden environment names. Wouldn't it make sense for smart-proxy to simply ignore modulepaths within these blocks, as they don't/can't specify environments?

They're not valid for static definitions, that's true, but it's perfectly allowable to have:

[master]
modulepath = /path/to/my/stuff/$environment

and then in your filesystem

/path/to/my/stuff/master
/path/to/my/stuff/production
/path/to/my/stuff/development

This is especially true when using git, where 'master' is the default branch. Worse, Puppet will assume that a static path in [master] is actually an environment called 'production' so we can't just ignore it.

I've added a specific remapping for master->production under certain logic which should fix the issue at hand - if not we can come back and make the logic more complex (again, sigh :P)