Project

General

Profile

Actions

Bug #27347

closed

Pin audited gem to <4.9

Added by Adam Ruzicka almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Looking into the issue I found out that audited changes is a hash with strings as keys, but the tests expect symbols as keys.

UsergroupTest::audit usergroup::roles.test_0002_should audit when a role is removed/de-assigned from a usergroup (from UsergroupTest__audit usergroup__roles)

Error Message

No audits found for usergroup-roles

Stacktrace

No audits found for usergroup-roles (Minitest::Assertion)
/home/jenkins/workspace/foreman_salt-pull-request/database/postgresql/label/fast/ruby/2.6/foreman/test/models/usergroup_test.rb:364   

Related issues 1 (0 open1 closed)

Related to Foreman - Refactor #27359: Update audited gem to 4.9.xClosedAdam RuzickaActions
Actions #1

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Adam Ruzicka
  • Pull request https://github.com/theforeman/foreman/pull/6913 added
Actions #2

Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6915 added
Actions #3

Updated by Adam Ruzicka almost 5 years ago

Audited 4.9.0 was released on 18.7.2019. This release changed audited_changes from hash with indifferent access to hash, where keys are strings. This change made all tests which accessed parts of the hash using symbols as keys fail.

Actions #4

Updated by Anonymous almost 5 years ago

Actions #5

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases 1.23.0 added
Actions #6

Updated by Tomer Brisker almost 5 years ago

  • Subject changed from User and UserGroup tests fail with no audits found to Pin audited gem to <4.9
  • Fixed in Releases 1.21.4, 1.22.1 added
Actions #7

Updated by Tomer Brisker almost 5 years ago

  • Category changed from Tests to Packaging
Actions #8

Updated by Adam Ruzicka almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #9

Updated by Adam Ruzicka almost 5 years ago

Actions #10

Updated by Adam Ruzicka almost 5 years ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/6913)
Actions #11

Updated by Anonymous almost 5 years ago

Actions

Also available in: Atom PDF