Project

General

Custom queries

Profile

Actions
Copy link

Refactor #27763

closed

remove redundant url_for

Added by Amir Fefer over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amir Fefer
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7015
Fixed in Releases:
1.24.0
Found in Releases:
Red Hat JIRA:

Description

when `url_for` gets a string it returns the same string

url_for(compute_resource_path(@compute_resource))

equals to:

compute_resource_path(@compute_resource)

therefore there are few cases that url_for is redundant.

#1

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7015 added
#2

Updated by The Foreman Bot over 5 years ago

  • Fixed in Releases 1.24.0 added
#3

Updated by Amir Fefer over 5 years ago

  • Status changed from Ready For Testing to Closed
#4

Updated by Tomer Brisker over 5 years ago

  • Category set to Rails
  • Fixed in Releases deleted (1.24.0)
#5

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.24.0 added
Actions
Copy link

Also available in: Atom PDF