Project

General

Profile

Actions

Refactor #29498

closed

make Plugin#pending_migration check plugin migrations instead of core ones

Added by Ondřej Ezr over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
DB migrations
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

`pending_migration` method is used to check whether plugin permissions and roles should be initialized.
That should be based on plugin's migrations, but the method is now checking the core migrations only, as the plugin registration goes before the migration paths registration.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #30821: ActiveModel::UnknownAttributeError: unknown attribute 'name' for PermissionClosedOndřej EzrActions
Actions #1

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ondřej Ezr
  • Pull request https://github.com/theforeman/foreman/pull/7574 added
Actions #2

Updated by The Foreman Bot over 4 years ago

  • Fixed in Releases 2.2.0 added
Actions #3

Updated by Ondřej Ezr over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added
Actions #5

Updated by Ewoud Kohl van Wijngaarden about 4 years ago

  • Related to Bug #30821: ActiveModel::UnknownAttributeError: unknown attribute 'name' for Permission added
Actions

Also available in: Atom PDF