Project

General

Profile

Bug #30209

Default patterns for "excluded_facts" setting are overly broad

Added by Marc Schmitzer over 2 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The default "excluded_facts" pattern list includes "en*v*" which excludes all fact names containing "env" if it is preceeded by "_" or "::".

While this is only a setting and can be changed, it is difficult to discover. I was not aware of the setting until I started debugging why some facts were present in puppetdb but not visible in Foreman.

I realize that this may not be easy to fix since changing the default setting may have negative effects.


Related issues

Related to Foreman - Refactor #24476: add SR-IOV virtual functions to NIC ignore list for fact importClosed

History

#1 Updated by Lukas Zapletal over 2 years ago

Hey, what fact is this filtering out?

#2 Updated by Lukas Zapletal over 2 years ago

  • Related to Refactor #24476: add SR-IOV virtual functions to NIC ignore list for fact import added

#3 Updated by Lukas Zapletal over 2 years ago

I think what we could do is to filter "eno*v*" instead, SRVIO should be onboard only.

https://github.com/theforeman/foreman/pull/5887#issuecomment-649431120

#4 Updated by Marc Schmitzer over 2 years ago

Lukas Zapletal wrote:

Hey, what fact is this filtering out?

The one I noticed is a custom fact called "<something>_environment". But we also have two facts "puppet_environmentpath" and "agent_specified_environment" in our PuppetDB that are not custom (I think) and affected by the "en*v*" pattern as well.

#5 Updated by Marc Schmitzer over 2 years ago

I just tested your suggested change to "eno*v*" and it has the desired effect: The missing facts appear in Foreman as they re-reported by the puppet agent.

Also available in: Atom PDF