Bug #30209
open
Default patterns for "excluded_facts" setting are overly broad
Description
The default "excluded_facts" pattern list includes "en*v*" which excludes all fact names containing "env" if it is preceeded by "_" or "::".
While this is only a setting and can be changed, it is difficult to discover. I was not aware of the setting until I started debugging why some facts were present in puppetdb but not visible in Foreman.
I realize that this may not be easy to fix since changing the default setting may have negative effects.
Updated by Lukas Zapletal almost 4 years ago
Hey, what fact is this filtering out?
Updated by Lukas Zapletal almost 4 years ago
- Related to Refactor #24476: add SR-IOV virtual functions to NIC ignore list for fact import added
Updated by Lukas Zapletal almost 4 years ago
I think what we could do is to filter "eno*v*" instead, SRVIO should be onboard only.
https://github.com/theforeman/foreman/pull/5887#issuecomment-649431120
Updated by Marc Schmitzer almost 4 years ago
Lukas Zapletal wrote:
Hey, what fact is this filtering out?
The one I noticed is a custom fact called "<something>_environment". But we also have two facts "puppet_environmentpath" and "agent_specified_environment" in our PuppetDB that are not custom (I think) and affected by the "en*v*" pattern as well.
Updated by Marc Schmitzer almost 4 years ago
I just tested your suggested change to "eno*v*" and it has the desired effect: The missing facts appear in Foreman as they re-reported by the puppet agent.