Project

General

Profile

Bug #3089

Updating settings causes settings page to load again within the page

Added by Dominic Cleal about 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Since #2969, updating a setting via the UI causes the request to be redirected back to the index on success and the settings page gets loaded within the settings page again, causing a huge mess in the UI.

Looks like this happens because process_response in application_controller had its JSON handling removed, and this is one instance where we legitimately perform model updates using JSON. Previously, it would just render the object.


Related issues

Related to Foreman - Feature #2969: remove all legacy api code in UI controllersClosed2013-08-25
Has duplicate Foreman - Bug #3100: Saving sso_signo in Settings/Auth returns whole foreman page instead of json partialDuplicate2013-09-16

Associated revisions

Revision 76fec074 (diff)
Added by Joseph Magen about 9 years ago

fixes #3089 - Updating settings causes settings page to load again within the page

Revision a619d98f (diff)
Added by Joseph Magen about 9 years ago

fixes #3089 - Updating settings causes settings page to load again within the page

(cherry picked from commit 76fec0747a538c639b9484c8e4c3d01916b891a0)

History

#1 Updated by Dominic Cleal about 9 years ago

  • Related to Feature #2969: remove all legacy api code in UI controllers added

#2 Updated by Dominic Cleal about 9 years ago

  • Has duplicate Bug #3100: Saving sso_signo in Settings/Auth returns whole foreman page instead of json partial added

#3 Updated by Joseph Magen about 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Joseph Magen

#5 Updated by Joseph Magen about 9 years ago

  • Status changed from Assigned to Ready For Testing

#6 Updated by Dominic Cleal about 9 years ago

  • Priority changed from High to Immediate

Lukas Zapletal, I'd recommend leaving the old "invalid" string in app/models/setting.rb in place when cherry picking so we don't add new strings into a stable branch. Or perhaps better is change it to "is invalid %s" (no ":") so it matches one of our existing strings.

#7 Updated by Joseph Magen about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#8 Updated by Lukas Zapletal about 9 years ago

  • Related to Tracker #3112: [TRACKER] Issues to be released in 1.3 RC or final added

#9 Updated by Lukas Zapletal about 9 years ago

  • Related to deleted (Tracker #3112: [TRACKER] Issues to be released in 1.3 RC or final)

Also available in: Atom PDF