Project

General

Profile

Bug #32840

Setting values have duplicate tooltips in Firefox

Added by Tomer Brisker 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

When hovering over a setting value in FF, two overlapping tooltips are shown: one triggered by EllipsisWithTooltip component, and one by the setting table item showing the default value and setting name.


Related issues

Related to Foreman - Bug #31855: Tables have overlaping text contentClosed

Associated revisions

Revision 4253d832 (diff)
Added by Tomer Brisker 4 months ago

Fixes #32840 - Avoid duplicate tooltips on settings (#8610)

  • Fixes #32840 - Avoid duplicate tooltips on settings

EllipsisWithTooltips causes a duplicate tooltip to be shown for setting
values in Firefox. There is no need to show a tooltip for long values,
since there is already a tooltip for showing the default. This removes
the duplicate tooltip and uses `ellipsis` class to only handle overflow
styling correctly.

  • Refs #32840 - move setting value formatting to cell formatter

Revision 62228620 (diff)
Added by Tomer Brisker 3 months ago

Refs #32840 - Fix setting editing

OverlayTrigger does some wired magic with children event handlers,
causing the onClick event of the direct child to be overriden. That
means that we must have a "dummy" child element to avoid the actual
onClick event from being overriden. See
https://github.com/react-bootstrap/react-bootstrap/blob/v0.33.1/src/OverlayTrigger.js#L272
for details.

History

#1 Updated by Tomer Brisker 4 months ago

  • Related to Bug #31855: Tables have overlaping text content added

#2 Updated by The Foreman Bot 4 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8610 added

#3 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.0.0 added

#4 Updated by Tomer Brisker 4 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8664 added

Also available in: Atom PDF