Project

General

Profile

Bug #33639

Reduce allocations in FactImporter#update_facts

Added by Jonathon Turel 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Jonathon Turel
Category:
Facts
Target version:
2.5.4
Difficulty:
Triaged:
No
Bugzilla link:
2011696
Pull request:
https://github.com/theforeman/foreman/pull/8833, https://github.com/theforeman/foreman/pull/8816, https://github.com/theforeman/foreman/pull/8820, https://github.com/theforeman/foreman/pull/8823, https://github.com/theforeman/foreman/pull/8818
Fixed in Releases:
2.5.4, 3.0.1, 3.1.0
Found in Releases:

Related issues

Related to Foreman - Bug #33585: Puma memory usage after update to 2.5Closed

Associated revisions

Revision aa602171 (diff)
Added by Jonathon Turel 8 months ago

Fixes #33639 - Reduce object allocations in FactImporter#update_facts

Revision 1fbcf6e4 (diff)
Added by Tomer Brisker 8 months ago

Refs #33639 - Only pull needed data for fact updates

Instead of initializing FactValue and FactName for all facts that need
updating, only pull the required columns from the DB and use them for
the update.

Revision 39004642 (diff)
Added by Tomer Brisker 8 months ago

Refs #33639 - Reduce array resizing in fact importer

Instead of starting with an empty array and resizing it for every fact
added, we can calculate the final array right away.

History

#1 Updated by The Foreman Bot 8 months ago

  • Assignee set to Jonathon Turel
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8816 added

#2 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases 3.1.0 added

#3 Updated by Jonathon Turel 8 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8818 added

#5 Updated by Tomer Brisker 8 months ago

  • Category set to Performance

#6 Updated by Tomer Brisker 8 months ago

  • Category changed from Performance to Facts

#7 Updated by Tomer Brisker 8 months ago

  • Bugzilla link set to 2011696

#8 Updated by Tomer Brisker 8 months ago

  • Target version set to 3.0.1

#9 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8820 added

#10 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8823 added

#11 Updated by Tomer Brisker 8 months ago

  • Fixed in Releases 3.0.1 added

#12 Updated by Tomer Brisker 8 months ago

  • Target version changed from 3.0.1 to 2.5.4

#13 Updated by Lukas Zapletal 8 months ago

  • Related to Bug #33585: Puma memory usage after update to 2.5 added

#14 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8833 added

#15 Updated by Tomer Brisker 8 months ago

  • Fixed in Releases 2.5.4 added

Also available in: Atom PDF