Project

General

Custom queries

Profile

Actions
Copy link

Refactor #35196

closed

Use assert_equal in rendered template snapshots

Added by Ewoud Kohl van Wijngaarden over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/9300
Fixed in Releases:
3.4.0
Found in Releases:
Red Hat JIRA:

Description

The current code uses assert false, "Rendered template ..." but this doesn't show you exactly what's wrong in a report like on Jenkins. By using assert_equal a diff is shown in the report.

Added by Ewoud Kohl van Wijngaarden over 2 years ago

Revision 59048d86 (diff)

Fixes #35196 - Use assert_equal to match rendered templates

This allows the report to properly show up in Jenkins, rather than the
unhelpful message that it didn't match.

Actions
Copy link

Also available in: Atom PDF