Actions
Refactor #3540
open
Change pluck('table.column') back to pluck(:column)
Status:
New
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
-
Description
For Rails 3.2.8 compatibility, we've changed a few instance of pluck(:column) to specify the table name to remove ambiguity (which 3.2.13 and higher can cope with). These can be reverted on Rails 4 or similar.
Updated by Dominic Cleal about 11 years ago
- Blocks Tracker #3157: Rails 4.1 upgrade tasks added
Updated by Dominic Cleal about 11 years ago
Updated by Petr Chalupa about 11 years ago
It should probably be reverted to pluck(:column), see https://github.com/rails/rails/blob/bf794bb36f3bd06e2e863cd6c6dfb6ceae116af2/activerecord/lib/active_record/relation/calculations.rb#L180-L184
Updated by Dominic Cleal about 11 years ago
- Subject changed from Change pluck('table.column') back to pluck('column') to Change pluck('table.column') back to pluck(:column')
- Description updated (diff)
Oops, thanks Petr. The string was laziness, I hadn't realised it was different!
Updated by Dominic Cleal about 11 years ago
- Subject changed from Change pluck('table.column') back to pluck(:column') to Change pluck('table.column') back to pluck(:column)
- Description updated (diff)
Updated by Ohad Levy about 10 years ago
- Translation missing: en.field_release set to 21
Updated by Ohad Levy about 10 years ago
- Translation missing: en.field_release deleted (
21)
Updated by Tom Caspy almost 10 years ago
I'm not sure I want this.
specifying the table name in situations where there's a join makes a lot of sense to me. it's more verbose, and feels right to me. let's keep it like it is.
Updated by The Foreman Bot about 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2639 added
- Pull request deleted (
)
Updated by Dominic Cleal almost 9 years ago
- Blocks deleted (Tracker #3157: Rails 4.1 upgrade tasks)
Updated by Dominic Cleal almost 9 years ago
- Related to Tracker #3157: Rails 4.1 upgrade tasks added
Updated by Dominic Cleal almost 9 years ago
- Status changed from Ready For Testing to New
- Pull request deleted (
https://github.com/theforeman/foreman/pull/2639)
Actions