Project

General

Profile

Refactor #3540

Change pluck('table.column') back to pluck(:column)

Added by Dominic Cleal almost 8 years ago. Updated over 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

For Rails 3.2.8 compatibility, we've changed a few instance of pluck(:column) to specify the table name to remove ambiguity (which 3.2.13 and higher can cope with). These can be reverted on Rails 4 or similar.


Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

History

#1 Updated by Dominic Cleal almost 8 years ago

#2 Updated by Dominic Cleal almost 8 years ago

b1e56e3c62535fd89ed4e226c56961cb5e8a3e3e #3538
65f764d6081b04cd03fa56a78e6281b5221b0bac #2579

#4 Updated by Dominic Cleal almost 8 years ago

  • Subject changed from Change pluck('table.column') back to pluck('column') to Change pluck('table.column') back to pluck(:column')
  • Description updated (diff)

Oops, thanks Petr. The string was laziness, I hadn't realised it was different!

#5 Updated by Dominic Cleal almost 8 years ago

  • Subject changed from Change pluck('table.column') back to pluck(:column') to Change pluck('table.column') back to pluck(:column)
  • Description updated (diff)

#6 Updated by Ohad Levy almost 7 years ago

  • Legacy Backlogs Release (now unused) set to 21

#7 Updated by Ohad Levy almost 7 years ago

  • Legacy Backlogs Release (now unused) deleted (21)

#8 Updated by Tom Caspy over 6 years ago

I'm not sure I want this.
specifying the table name in situations where there's a join makes a lot of sense to me. it's more verbose, and feels right to me. let's keep it like it is.

#9 Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2639 added
  • Pull request deleted ()

#10 Updated by Dominic Cleal over 5 years ago

#11 Updated by Dominic Cleal over 5 years ago

#12 Updated by Dominic Cleal over 5 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2639)

Also available in: Atom PDF