Project

General

Profile

Bug #3697

Field Validations Should be more Comprehensive

Added by Stephen Benjamin over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Stephen Benjamin
Category:
Rails
Target version:
1.4.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Hostnames:
should be validated against http://tools.ietf.org/html/rfc1123
e.g. if user creates hostname with a _, which foreman allows, will
cause problems alter during provisioning

IP Addresses:
validation should be extended to check if each octet is < 255

Related issues

Related to Foreman - Feature #3701: Fail if a hostname has a dot in itClosed2013-11-20
Related to Foreman - Bug #4519: Renaming host with / in name causes "No route matches" errorClosed2014-03-03
Has duplicate Foreman - Bug #3156: Foreman allows underscores in hostnamesDuplicate2013-09-27

Associated revisions

Revision 4bae5ced (diff)
Added by Stephen Benjamin over 8 years ago

fixes #3697, #3701 - more comprehensive field validations

Revision dbaa47b7 (diff)
Added by Dominic Cleal over 8 years ago

refs #3697, #3701 - fix test with multiple validation failures

Revision f0e33f83 (diff)
Added by Stephen Benjamin over 8 years ago

fixes #3697, #3701 - more comprehensive field validations

(cherry picked from commit 4bae5cedb8ab562b6c397234c5cb1cfd604fde74)

Revision 9f02cefa (diff)
Added by Dominic Cleal over 8 years ago

refs #3697, #3701 - fix test with multiple validation failures

(cherry picked from commit dbaa47b718a25992065cc6e0afea78bed1171f7e)

History

#1 Updated by Dominic Cleal over 8 years ago

  • Related to Feature #3701: Fail if a hostname has a dot in it added

#2 Updated by Dominic Cleal over 8 years ago

  • Category set to Rails
  • Status changed from New to Ready For Testing
  • Target version set to 1.9.2
  • Legacy Backlogs Release (now unused) set to 2

#3 Updated by Anonymous over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 8 years ago

  • Related to Bug #4519: Renaming host with / in name causes "No route matches" error added

#5 Updated by Dominic Cleal about 8 years ago

  • Has duplicate Bug #3156: Foreman allows underscores in hostnames added

Also available in: Atom PDF