Project

General

Profile

Bug #4119

need way to pass headers with command call

Added by Thomas McKay over 6 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Hammer core
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

While writing "hammer subscription import --file manifest.zip" for katello, I discovered that there were several issues associated with sending a binary file with an api request. Pull-requests to follow shortly.

Associated revisions

Revision 480df0eb (diff)
Added by Thomas McKay over 6 years ago

refs #4119 - hammer-manifest - add headers to call method

Revision 27ab9860 (diff)
Added by Thomas McKay over 6 years ago

refs #4119 - hammer-manifest - do not convert params to_json since this prevents passing File objects to POST

Revision 4f0d3212
Added by Tomas Strachota over 6 years ago

Merge pull request #69 from thomasmckay/hammer-manifest

refs #4119 - hammer-manifest - add headers to call method

Revision 9deebd7c (diff)
Added by Thomas McKay over 6 years ago

refs #4119 - hammer-manifest - add request_headers method to allow exteners of WriteCommand to override and pass

refs #4119 - hammer-manifest - updated tests to handle optional headers

Revision 1d722f34
Added by Tomas Strachota over 6 years ago

Merge pull request #71 from thomasmckay/hammer-manifest

refs #4119 - hammer-manifest - add request_headers method to allow exten...

Revision c24a3420
Added by mbacovsky over 6 years ago

Merge pull request #22 from thomasmckay/hammer-manifest

refs #4119 - hammer-manifest - do not convert params to_json since this ...

Revision 5b659f07 (diff)
Added by Martin Bacovsky over 6 years ago

refs #4119 - hammer-manifest - revert the fix as it breaks stuff

Also available in: Atom PDF