Bug #6700

Proxy::Puppet::Runner incorrectly checked $? for success

Added by Dominic Cleal almost 4 years ago. Updated 6 days ago.

Status:Closed
Priority:Normal
Assignee:Aaron Stone
Category:Tests
Target version:1.6.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/smart-proxy/pull/187

Description

"The popen test was looking at $?, but it wasn't set by the method under test. Testing Ruby's popen method isn't terribly helpful, it's a built-in.

This replaces the popen test with a test for the shell_command wrapper and adds tests for the other methods in Proxy::Puppet::Runner."

Associated revisions

Revision 2cba6063
Added by Aaron Stone almost 4 years ago

fixes #6700 - tests for Proxy::Puppet::Runner shell methods

History

#1 Updated by Aaron Stone almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF