Bug #6825

refactor api/v2/filters_controller.rb to use find_optional_nested_object and add Authorizable to class Role

Added by Joseph Magen almost 4 years ago. Updated 8 days ago.

Status:Closed
Priority:Normal
Assignee:Joseph Magen
Category:API
Target version:1.6.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/foreman/pull/1630

Description

after refactoring filters_controller to use find_optional_nested_object, it was discovered that Role doesn't respond to #authorized method, so include Authorizable needs to be added to role.rb

This is commit was need for tests to pass in PR #4181


Related issues

Related to Foreman - Bug #14182: Roles index does not use authorize scope Closed 03/14/2016

Associated revisions

Revision 39054ec4
Added by Joseph Magen almost 4 years ago

fixes #6825 - refactor api/v2/filters_controller.rb to use find_optional_nested_object and add Authorizable to class Role

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1630 added

#2 Updated by Dmitri Dolguikh almost 4 years ago

  • Target version changed from 1.8.0 to 1.7.5

#3 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 10

#4 Updated by Joseph Magen almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Yama Kasi almost 4 years ago

This fix doesn't work on 1.5.2 ?

It seems to remain.

#6 Updated by Dominic Cleal almost 4 years ago

Yama Kasi wrote:

This fix doesn't work on 1.5.2 ?

It seems to remain.

Huh? I think you have the wrong ticket.

#7 Updated by Yama Kasi almost 4 years ago

Dominic Cleal wrote:

Yama Kasi wrote:

This fix doesn't work on 1.5.2 ?

It seems to remain.

Huh? I think you have the wrong ticket.

Nudik pointed me to this and indeed it happens on 1.5.2 (too)!

#8 Updated by Marek Hulán over 2 years ago

  • Related to Bug #14182: Roles index does not use authorize scope added

Also available in: Atom PDF