Project

General

Profile

Bug #7451

Review whitespace in extracted strings

Added by Dominic Cleal over 4 years ago. Updated 6 months ago.


Description

Many of the Hammer & Foreman strings contain whitespace at the end, which is causing problems for translators as some are omitting the whitespace and some are leaving it in.

Please review all extracted strings and check whether whitespace is mandatory - if it's part of a sentence, leave it in the string, if it's some sort of UI padding then remove it and append it after the i18n string. If it's not needed, please remove the space.


Related issues

Related to Katello - Bug #22504: Hammer expects improper sentences in testsClosed2018-02-02
Related to Katello - Bug #23484: hammer-cli-katello should check string formats in testsClosed2018-05-03

Associated revisions

Revision d45d3167 (diff)
Added by Oleh Fedorenko over 1 year ago

Fixes #7451 - Review whitespace in extracted strings

Revision c836ba96 (diff)
Added by Oleh Fedorenko about 1 year ago

Fixes #7451 - Review whitespace in extracted strings

Revision 18013319 (diff)
Added by Oleh Fedorenko about 1 year ago

Fixes #7451 - Review whitespace in extracted strings

Revision 170e7d8a (diff)
Added by Oleh Fedorenko about 1 year ago

Fixes #7451 - Review whitespace in extracted strings

Revision c0983171 (diff)
Added by Tomas Strachota about 1 year ago

Refs #7451 - fix "unknown version" message

Fixes formatting of "unknown version" message that was turned into a
sentence by mistake.

Before this patch:
```
$ hammer --version
hammer (0.12.pre.develop) * hammer_cli_foreman (0.12.pre.develop) * hammer_cli_foreman_tasks (Unknown version.)
```

With this patch:
```
$ hammer --version
hammer (0.12.pre.develop) * hammer_cli_foreman (0.12.pre.develop) * hammer_cli_foreman_tasks (unknown version)
```

Revision 30b048ca (diff)
Added by Tomas Strachota about 1 year ago

Refs #7451 - tests for message formats (#266)

Revision 61bd20f5 (diff)
Added by Tomas Strachota 6 months ago

Refs #7451 - allow skipping message tests (#292)

Revision 7f94264c (diff)
Added by Tomas Strachota 6 months ago

Refs #7451 - tests for message formats

History

#1 Updated by Dominic Cleal over 4 years ago

If I may add this too, it would also be great to review punctuation at the end of strings as this is also very inconsistent. If you type "hammer" with hammer-cli-foreman installed, many of the command descriptions have a trailing "." while others don't. I don't think it should be there.

#2 Updated by Oleh Fedorenko over 1 year ago

  • Assignee set to Oleh Fedorenko
  • Status changed from New to Assigned

#3 Updated by The Foreman Bot over 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/258 added

#4 Updated by Oleh Fedorenko over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#5 Updated by Oleh Fedorenko over 1 year ago

  • Status changed from Closed to Assigned

#6 Updated by The Foreman Bot over 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/265 added

#7 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/349 added

#8 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/266 added

#9 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/352 added

#10 Updated by Oleh Fedorenko about 1 year ago

  • Status changed from Ready For Testing to Closed

#11 Updated by Andrew Kofink about 1 year ago

  • Related to Bug #22504: Hammer expects improper sentences in tests added

#12 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/268 added

#13 Updated by Andrew Kofink 12 months ago

  • Related to Bug #23484: hammer-cli-katello should check string formats in tests added

#14 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/292 added

Also available in: Atom PDF