Project

General

Profile

Refactor #7567

fix deprecated find_by_[attribute]_or_create dynamic methods

Added by Joseph Magen almost 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

Associated revisions

Revision 0f436556 (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #7567 - Substitute find_or_create_by by first_or_create

Rails 3 and 4 both support the syntax 'where(args).first_or_create'.
find_or_create_by is no longer valid on Rails 4 so we should remove it
here already

History

#1 Updated by Joseph Magen almost 5 years ago

#2 Updated by The Foreman Bot almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Target version set to 1.7.3
  • Pull request https://github.com/theforeman/foreman/pull/1785 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 5 years ago

  • Target version changed from 1.7.3 to 1.7.2

#4 Updated by Joseph Magen almost 5 years ago

  • Target version deleted (1.7.2)

#5 Updated by Dominic Cleal almost 4 years ago

  • Subject changed from fix deprecated find_by_[attribute] dynamic methods to fix deprecated find_by_[attribute]_or_create dynamic methods
  • Legacy Backlogs Release (now unused) set to 63

#6 Updated by Dominic Cleal almost 4 years ago

  • Tracker changed from Bug to Refactor
  • Assignee changed from Joseph Magen to Daniel Lobato Garcia

#7 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF