Project

General

Profile

Actions
Copy link

Bug #8922

closed

authorized_smart_proxy_features should not fail if not implemented

Added by Daniel Lobato Garcia about 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Plugin integration
Target version:
1.8.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2075
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently it raises a NotImplementedError. In case the user has a plugin that uses it and the plugin with a fact parser does not implement authorized_smart_proxy_features, this will make foreman fail in various parts (anywhere add_smart_proxy_filters is used), including tests.

Instead we can default to returning an empty array with no features.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Feature #8484: Make SmartProxyAuth concern more useful to pluginsClosedStephen Benjamin11/24/2014Actions
Actions
Copy link
 #1

Updated by Dominic Cleal about 10 years ago

  • Category set to Plugin integration
Actions
Copy link
 #2

Updated by The Foreman Bot about 10 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2075 added
  • Pull request deleted ()
Actions
Copy link
 #3

Updated by Dominic Cleal about 10 years ago

  • Translation missing: en.field_release set to 28
Actions
Copy link
 #4

Updated by Dominic Cleal about 10 years ago

  • Related to Feature #8484: Make SmartProxyAuth concern more useful to plugins added
Actions
Copy link
 #5

Updated by Daniel Lobato Garcia about 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF