Project

General

Profile

Bug #8922

authorized_smart_proxy_features should not fail if not implemented

Added by Daniel Lobato Garcia almost 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Plugin integration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Currently it raises a NotImplementedError. In case the user has a plugin that uses it and the plugin with a fact parser does not implement authorized_smart_proxy_features, this will make foreman fail in various parts (anywhere add_smart_proxy_filters is used), including tests.

Instead we can default to returning an empty array with no features.


Related issues

Related to Foreman - Feature #8484: Make SmartProxyAuth concern more useful to pluginsClosed2014-11-24

Associated revisions

Revision 282d4ee6 (diff)
Added by Daniel Lobato Garcia almost 7 years ago

Fixes #8922 - authorized_smart_proxy_features should not fail if not implemented

History

#1 Updated by Dominic Cleal almost 7 years ago

  • Category set to Plugin integration

#2 Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2075 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

#4 Updated by Dominic Cleal almost 7 years ago

  • Related to Feature #8484: Make SmartProxyAuth concern more useful to plugins added

#5 Updated by Daniel Lobato Garcia almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF