Refactor #15846

Rename use_puppet_default in lookup values to skip_foreman

Added by Shimon Shtein 7 months ago. Updated 5 months ago.

Status:Closed
Priority:Normal
Assigned To:Shimon Shtein
Category:Smart Variables
Target version:Team Ivan Iteration 2
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3870, https://github.com/theforeman/foreman/pull/3833, https://github.com/theforeman/foreman/pull/3681
Story points-
Velocity based estimate-
Release1.14.0Release relationshipAuto

Description

As part of the effort to remove puppet specific properties from the core, we decided to "upgrade" use_puppet_default into something that any type of parameter could benefit from. We want to rename it to skip_foreman since it's a generic behavior that could be served by the core. The meaning remains pretty much the same - the flag signals the core that it should not manage (and serve) this parameter for a given host.


Related issues

Related to Foreman - Tracker #9596: Extract Puppet functionality to a plugin New 03/01/2015
Related to Foreman - Refactor #12822: Separate LookupValue to different classes per LookupKey type New 12/15/2015

Associated revisions

Revision 569650b7
Added by Shimon Shtein 6 months ago

Fixes #15846 - Renamed use_puppet_default to omit in LookupValue

Revision a56e7de3
Added by Dominic Cleal 5 months ago

refs #15846 - hide API deprecation warnings in tests

Revision 63b92169
Added by Dominic Cleal 5 months ago

refs #15846 - correct spelling of parameter

History

#1 Updated by Shimon Shtein 7 months ago

  • Related to Tracker #9596: Extract Puppet functionality to a plugin added

#2 Updated by Ivan Necas 7 months ago

  • Status changed from New to Assigned
  • Assigned To set to Shimon Shtein
  • Target version set to Team Ivan Iteration 1

#3 Updated by Shimon Shtein 7 months ago

  • Related to Refactor #12822: Separate LookupValue to different classes per LookupKey type added

#4 Updated by The Foreman Bot 7 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3681 added

#5 Updated by Ivan Necas 6 months ago

  • Target version changed from Team Ivan Iteration 1 to Team Ivan Iteration 2

#6 Updated by Shimon Shtein 5 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal 5 months ago

  • Category set to Smart Variables
  • Release set to 1.14.0

#8 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman/pull/3833 added

#9 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman/pull/3870 added

Also available in: Atom PDF