Project

General

Profile

Actions
Copy link

Refactor #22529

closed

Refactor Template rendering to use a proper rendering service

Added by Timo Goebel almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Timo Goebel
Category:
Templates
Target version:
1.20.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5683
Fixed in Releases:
1.20.0
Found in Releases:
Red Hat JIRA:

Description

We should refactor template rendering to use a rendering service class and the template scope should also be a dedicated object and not some controller class.

Related issues 14 (1 open — 13 closed)

Related to Foreman Remote Execution - Refactor #24130: plugin should work with new template rendering engine from coreClosedTimo GoebelActions
Related to Boot disk - Refactor #24147: plugin should work with new template rendering engine from coreClosedTimo GoebelActions
Related to Discovery - Refactor #24148: plugin should work with new template rendering engine from coreClosedTimo GoebelActions
Related to Katello - Refactor #24149: Katello should use Foreman plugin API to register template macrosClosedTimo GoebelActions
Related to Foreman - Feature #24294: add snapshot tests for templatesClosedTimo GoebelActions
Related to Foreman - Feature #24359: Create localized copies of templates for version controlNewActions
Related to Foreman - Refactor #24484: snippet rendering should use source to find snippetClosedTimo GoebelActions
Related to Foreman - Refactor #24496: remove unattended helperClosedTimo GoebelActions
Related to Foreman - Bug #24503: snippets macro does not render a snippet partial from filesystemClosedTimo GoebelActions
Related to Katello - Bug #24513: React pages don't include Rails url_helpersClosedAndrew KofinkActions
Related to Foreman - Bug #25070: Macro snippet_if_exists no longer worksClosedMarek HulánActions
Related to Foreman - Bug #25128: Template Renderer: Variables loader registry is not kept when the class is inheritedClosedActions
Related to foreman_setup - Bug #25734: wrong number of arguments (given 1, expected 0)ClosedLukas ZapletalActions
Related to Foreman - Bug #25767: XenServer provisioning broken in 1.20ClosedShimon ShteinActions
Actions
Copy link
 #1

Updated by google classroom over 6 years ago

removed spam bot comment

Actions
Copy link
 #2

Updated by Timo Goebel over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Timo Goebel
Actions
Copy link
 #3

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5683 added
Actions
Copy link
 #4

Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
Actions
Copy link
 #5

Updated by Timo Goebel over 6 years ago

  • Related to Refactor #24130: plugin should work with new template rendering engine from core added
Actions
Copy link
 #6

Updated by Timo Goebel over 6 years ago

  • Related to Refactor #24147: plugin should work with new template rendering engine from core added
Actions
Copy link
 #7

Updated by Timo Goebel over 6 years ago

  • Related to Refactor #24148: plugin should work with new template rendering engine from core added
Actions
Copy link
 #8

Updated by Timo Goebel over 6 years ago

  • Related to Refactor #24149: Katello should use Foreman plugin API to register template macros added
Actions
Copy link
 #9

Updated by Timo Goebel over 6 years ago

Actions
Copy link
 #10

Updated by Marek Hulán over 6 years ago

  • Related to Feature #24359: Create localized copies of templates for version control added
Actions
Copy link
 #11

Updated by Marek Hulán over 6 years ago

  • Target version set to 1.20.0
  • Triaged set to No
  • Fixed in Releases 1.20.0 added
Actions
Copy link
 #12

Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #13

Updated by Timo Goebel over 6 years ago

  • Related to Refactor #24484: snippet rendering should use source to find snippet added
Actions
Copy link
 #14

Updated by Timo Goebel over 6 years ago

Actions
Copy link
 #15

Updated by Timo Goebel over 6 years ago

  • Related to Bug #24503: snippets macro does not render a snippet partial from filesystem added
Actions
Copy link
 #16

Updated by Andrew Kofink over 6 years ago

  • Related to Bug #24513: React pages don't include Rails url_helpers added
Actions
Copy link
 #17

Updated by Marek Hulán about 6 years ago

  • Related to Bug #25070: Macro snippet_if_exists no longer works added
Actions
Copy link
 #18

Updated by Timo Goebel about 6 years ago

  • Related to Bug #25128: Template Renderer: Variables loader registry is not kept when the class is inherited added
Actions
Copy link
 #19

Updated by Shimon Shtein almost 6 years ago

  • Related to Bug #25734: wrong number of arguments (given 1, expected 0) added
Actions
Copy link
 #20

Updated by Shimon Shtein almost 6 years ago

  • Related to Bug #25767: XenServer provisioning broken in 1.20 added
Actions
Copy link

Also available in: Atom PDF