Project

General

Custom queries

Profile

Actions

Bug #10689

closed

Unattended controller permission check does not work

Added by Lukas Zapletal almost 10 years ago. Updated almost 9 years ago.

Status:
Duplicate
Priority:
Normal
Category:
Unattended installations
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Create a non-admin user (e.g. viewer role only), create new host, and as the viewer user log on and try to view a template.

2015-06-03 14:35:41 [I] Started GET "/unattended/iPXE?hostname=bdsktest.local.lan" for 127.0.0.1 at 2015-06-03 14:35:41 +0200
2015-06-03 14:35:41 [I] Processing by UnattendedController#iPXE as HTML
...
app/controllers/application_controller.rb:224:in `block (2 levels) in render_403'
app/controllers/application_controller.rb:223:in `render_403'
app/controllers/application_controller.rb:63:in `deny_access'
app/controllers/application_controller.rb:55:in `authorize'
app/controllers/unattended_controller.rb:20:in `block (2 levels) in <class:UnattendedController>'
app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
lib/middleware/catch_json_parse_errors.rb:9:in `call'

We have two issues basically:

A) Permissions are not checked properly (we obviously use template kinds as actions and we don't have such permissions)
B) Method render_403 does not work from UnattendedController context (layout error).


Related issues 3 (0 open3 closed)

Related to Foreman - Bug #2892: unattended spoof mode only work for an administratorResolved08/07/2013Actions
Related to Foreman - Bug #15490: CVE-2016-4995 - view_hosts permissions/filters not checked for provisioning template previewsClosedLukas Zapletal06/22/2016Actions
Related to Foreman - Refactor #13039: Remove DB queries from class of UnattendedControllerClosedDominic Cleal01/07/2016Actions
#1

Updated by Dominic Cleal almost 10 years ago

  • Related to Bug #2892: unattended spoof mode only work for an administrator added
#4

Updated by The Foreman Bot almost 10 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2428 added
  • Pull request deleted ()
#5

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #15490: CVE-2016-4995 - view_hosts permissions/filters not checked for provisioning template previews added
#6

Updated by Dominic Cleal almost 9 years ago

  • Related to Refactor #13039: Remove DB queries from class of UnattendedController added
#8

Updated by Dominic Cleal almost 9 years ago

  • Status changed from Ready For Testing to Duplicate
Actions

Also available in: Atom PDF