Project

General

Profile

Actions

Bug #11749

closed

new host puppet environment jquery selector too liberal

Added by Justin Sherrill over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Category:
Host creation
Target version:
Difficulty:
medium
Triaged:
Fixed in Releases:
Found in Releases:

Description

When creating a host or hostgroup and selecting just the puppet environment, no puppet classes get loaded on the 'puppet classes' tab. The user has to select a lifecycle env and content view and only then will they be loaded.

Once those are selected the user can change the puppet env at will, but this should not be required


Related issues 1 (0 open1 closed)

Related to Katello - Bug #13988: Hostgroups Puppet Class management issueRejectedDavid Davis03/01/2016Actions
Actions #1

Updated by Eric Helms over 8 years ago

  • translation missing: en.field_release changed from 70 to 86
Actions #2

Updated by Eric Helms almost 8 years ago

  • translation missing: en.field_release changed from 86 to 144
Actions #3

Updated by Eric Helms almost 8 years ago

  • translation missing: en.field_release changed from 144 to 168
Actions #4

Updated by Eric Helms almost 8 years ago

  • translation missing: en.field_release deleted (168)
Actions #5

Updated by Justin Sherrill almost 8 years ago

  • Assignee set to Justin Sherrill
  • Priority changed from Normal to High
  • translation missing: en.field_release set to 143
  • Difficulty changed from easy to medium
Actions #6

Updated by Justin Sherrill over 7 years ago

  • Related to Bug #13988: Hostgroups Puppet Class management issue added
Actions #7

Updated by Justin Sherrill over 7 years ago

  • Project changed from Katello to Foreman
  • Subject changed from puppet class population on new host/hostgroup page requires lifecycle env/content view selection to new host puppet environment jquery selector too liberal
  • Category changed from 83 to Host creation
  • Status changed from New to Assigned

This appears to be a result of https://github.com/theforeman/foreman/blob/develop/app/assets/javascripts/application.js#L387

this selector:

$('select[name*=environment_id]')

seems to be matching 'name=host[environment_id]' but its also matching 'name=host[content_facet_attributes][lifecycle_environment_id]'

We should make the selector more restrictive. Moving to foreman

Actions #8

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3642 added
Actions #9

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release deleted (143)
Actions #10

Updated by Justin Sherrill over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #11

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 161
Actions

Also available in: Atom PDF