Project

General

Profile

Actions
Copy link

Bug #11749

closed

new host puppet environment jquery selector too liberal

Added by Justin Sherrill about 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Justin Sherrill
Category:
Host creation
Target version:
1.12.1
Difficulty:
medium
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3642
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

When creating a host or hostgroup and selecting just the puppet environment, no puppet classes get loaded on the 'puppet classes' tab. The user has to select a lifecycle env and content view and only then will they be loaded.

Once those are selected the user can change the puppet env at will, but this should not be required

Related issues 1 (0 open — 1 closed)

Related to Katello - Bug #13988: Hostgroups Puppet Class management issueRejectedDavid Davis03/01/2016Actions
Actions
Copy link
 #1

Updated by Eric Helms almost 9 years ago

  • Translation missing: en.field_release changed from 70 to 86
Actions
Copy link
 #2

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release changed from 86 to 144
Actions
Copy link
 #3

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release changed from 144 to 168
Actions
Copy link
 #4

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release deleted (168)
Actions
Copy link
 #5

Updated by Justin Sherrill over 8 years ago

  • Assignee set to Justin Sherrill
  • Priority changed from Normal to High
  • Translation missing: en.field_release set to 143
  • Difficulty changed from easy to medium
Actions
Copy link
 #6

Updated by Justin Sherrill over 8 years ago

  • Related to Bug #13988: Hostgroups Puppet Class management issue added
Actions
Copy link
 #7

Updated by Justin Sherrill over 8 years ago

  • Project changed from Katello to Foreman
  • Subject changed from puppet class population on new host/hostgroup page requires lifecycle env/content view selection to new host puppet environment jquery selector too liberal
  • Category changed from 83 to Host creation
  • Status changed from New to Assigned

This appears to be a result of https://github.com/theforeman/foreman/blob/develop/app/assets/javascripts/application.js#L387

this selector:

$('select[name*=environment_id]')

seems to be matching 'name=host[environment_id]' but its also matching 'name=host[content_facet_attributes][lifecycle_environment_id]'

We should make the selector more restrictive. Moving to foreman

Actions
Copy link
 #8

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3642 added
Actions
Copy link
 #9

Updated by Dominic Cleal over 8 years ago

  • Translation missing: en.field_release deleted (143)
Actions
Copy link
 #10

Updated by Justin Sherrill over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Dominic Cleal over 8 years ago

  • Translation missing: en.field_release set to 161
Actions
Copy link

Also available in: Atom PDF