Project

General

Profile

Bug #11776

assignment of default org and location to new hosts makes org/location invalid

Added by Justin Sherrill over 7 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Puppet integration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

This change: https://github.com/theforeman/foreman/commit/8809a63b93b3f79eecb33a4757c4c13d2cbf4421

meant that new hosts checking in with puppet were assigned to the default org and location (as determined by the settings).

The current fact importing creates domains and puppet env, but does not associate these items to the host's organization and location.

In addition the location is not associated to the organization (which seems to also be causing a problem).

Steps to reproduce:

1) install foreman specifying a default org and location
2) let a puppet client check in
3) visit the org edit page

you'll notice lots of errors:

you cannot remove locations that are used by hosts or inherited.
you cannot remove domains that are used by hosts or inherited.
you cannot remove environments that are used by hosts or inherited.


Related issues

Related to Foreman - Bug #9654: If taxonomies are seeded, they should be the default orgsClosed2015-03-05

Associated revisions

Revision 7df48f20 (diff)
Added by Stephen Benjamin over 7 years ago

refs #11776 - do not set default taxonomy settings by default

This reverts commit 8809a63b93b3f79eecb33a4757c4c13d2cbf4421.

History

#1 Updated by Stephen Benjamin over 7 years ago

  • Related to Bug #9654: If taxonomies are seeded, they should be the default orgs added

#2 Updated by Stephen Benjamin over 7 years ago

This bug was always there, but my PR just exposed Katello to it now that it's a "default" thing. After spending some time to see what I could do to fix it, I'm inclined to revert the PR from #9654 so this brokenness isn't default behavior.

The actual fix I think would be pretty invasive and leaves open a million questions. It really goes to the core of some of the usability concerns of taxonomies.

Should we really let host `import_facts` save with :validate => false? And the `set_taxonomies` method lets a host fact from the host determine the taxonomies. Does that mean we let host fact automagically force put objects in different taxonomies? etc.

#3 Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2702 added
  • Pull request deleted ()

#4 Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • Assignee set to Stephen Benjamin
  • % Done changed from 0 to 100
  • Legacy Backlogs Release (now unused) set to 63

Also available in: Atom PDF