Bug #11921
closedFeatures in controller authentication are not loaded correctly if you modify them from plugins
Description
We use add_smart_proxy_filters
helper to configure authentication for requests coming from proxy (usually facts/reports). We pass features of proxies that should be considered as authenticated but since it's on class definition level, it evaluates during load time. If we register new importers that adds new potential feature, they are not re-evaluated. We should use pass Procs and evaluate them during runtime if we need dynamic list.
Updated by The Foreman Bot over 9 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2752 added
- Pull request deleted (
)
Updated by Marek Hulán over 9 years ago
For reproducers: it happens in development env if something loads v2 hosts controller (e.g. foreman-tasks) because it includes some concern. Then when another plugin registers new fact importer (foreman_chef, or I suppose foreman_salt as well) you won't see it in #require_smart_proxy_or_login among features hence authentication fails.
Updated by Marek Hulán over 9 years ago
- Related to Feature #8484: Make SmartProxyAuth concern more useful to plugins added
Updated by Marek Hulán over 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 1d0315e0630f23ca6c794d456d076c00020df275.
Updated by Dominic Cleal over 9 years ago
- Translation missing: en.field_release set to 104