Bug #12611
closed
CVE-2015-7518 - Smart class parameters/variables shown on host edit allows stored XSS in description
Added by Dominic Cleal about 9 years ago.
Updated over 6 years ago.
Description
Reported by Tomer Brisker to foreman-security:
I have discovered a stored XSS vulnerability in the host and hostgroup edit forms caused by smart class parameters and smart variables.
These forms display a popover that shows additional info about any of the parameters that can be overridden. The popover is rendered with HTML but contains values that can be input by a user - the parameter description, and in develop branch also the inherited value.
Effectively, any user who can edit parameters can input arbitrary HTML or JS into the description field or the default value, which will be executed once the popover is triggered by any other user.
This affects all versions of Foreman.
CVE identifier is CVE-2015-7518.
- Subject changed from Smart class parameters/variables shown on host edit allows stored XSS in description to CVE-2015-7518 - Smart class parameters/variables shown on host edit allows stored XSS in description
- Description updated (diff)
- Status changed from New to Ready For Testing
- Assignee set to Tomer Brisker
- Pull request https://github.com/theforeman/foreman/pull/2936 added
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- Translation missing: en.field_release set to 63
The patch fixes a few distinct XSS paths in the same information popups:
- Source name in global parameters, e.g. the name of a host group (since #7163 in 1.7.0)
- Description field in smart variables/class parameters (since 1.2 or earlier)
- Matcher in smart variables/class parameter overrides (since 1.2 or earlier)
- Inherited value in smart variables/class parameter overrides (1.11/develop only, not released)
- Related to Feature #7163: In host's edit page, show the source for the value of puppet class parameters added
- Bugzilla link set to 1297040
Also available in: Atom
PDF