Project

General

Profile

Actions

Refactor #12935

open

Check js code against jQuery upgrade guide and release notes

Added by Tomer Brisker over 8 years ago. Updated over 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

jQuery has been upgraded from 1.7.2 to 1.11.
There have been several changes to the jQuery code that may need corrections in our js code.
1.8 Release notes - https://blog.jquery.com/2012/08/09/jquery-1-8-released/
1.9 Upgrade Guide - http://jquery.com/upgrade-guide/1.9
1.10 Release notes - https://blog.jquery.com/2013/05/24/jquery-1-10-0-and-2-0-1-released/
1.11 Release notes - http://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/
Most of the breaking changes are cause by the 1.9 version.


Related issues 2 (0 open2 closed)

Related to Foreman - Refactor #8705: Update jQuery to recent versionClosed12/14/2014Actions
Related to Foreman - Bug #12934: Unhiding paramter values clears their valueClosedOri Rabin12/24/2015Actions
Actions #1

Updated by Tomer Brisker over 8 years ago

Actions #2

Updated by Tomer Brisker over 8 years ago

  • Related to Bug #12934: Unhiding paramter values clears their value added
Actions #3

Updated by Tomer Brisker over 8 years ago

  • Subject changed from Check js code against jQuery upgrade guides and release notes to Check js code against jQuery upgrade guide and release notes
  • Description updated (diff)
Actions #4

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 71
Actions #5

Updated by Shlomi Zadok about 8 years ago

  • Assignee changed from Tomer Brisker to Shlomi Zadok
Actions #6

Updated by The Foreman Bot about 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3241 added
Actions #7

Updated by Dominic Cleal about 8 years ago

  • translation missing: en.field_release deleted (71)

I'm tentatively removing this from the 1.11.0 blocker list as it appears the changes are more to fix deprecations and not bugs. Please correct me if I've missed something important that will be needed in 1.11.

Actions #8

Updated by Tomer Brisker about 8 years ago

Dominic - as far as I can tell none of these are breaking changes, if anything breaks we can cherry pick back to 1.11.1 if needed. This should however land in 1.12 so that hopefully by 1.13 we can get to jQuery 2 or even 3.

Actions #9

Updated by Shlomi Zadok over 7 years ago

  • Assignee deleted (Shlomi Zadok)
Actions #10

Updated by Shlomi Zadok over 7 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3241)
Actions

Also available in: Atom PDF