Actions
Refactor #13440
closed
Replace Host::Base#model_name to prevent Rails 4.2 conflict
Description
Rails 4.2 implements #model_name in ActiveRecord::Base as an instance method rather than a class method (in 4.1 and older), changed in https://github.com/rails/rails/commit/6b0e834.
Our HasManyCommon concern adds a model_name method to Host::Base as an extension of the model/model_id association to the Model er, model. This will need to be removed to ensure the AR method continues to work.
When our model is in place, links to hosts can't be generated in Rails 4.2 as they return nil or string values from our implementation Host::Base#model_name rather than the ActiveModel::Name object expected.
Updated by Dominic Cleal over 8 years ago
- Blocks Feature #13244: Upgrade Ruby on Rails to 4.2 added
Updated by The Foreman Bot over 8 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3133 added
Updated by Dominic Cleal over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 7c67160944db2904b06e10af24af1013f51810b0.
Updated by Dominic Cleal over 8 years ago
- Translation missing: en.field_release set to 71
Updated by Dominic Cleal over 8 years ago
- Related to Bug #14227: Discovery mailer fails for hosts without model name added
Updated by Lukas Zapletal over 8 years ago
- Related to Refactor #14236: Rename model_name to hardware_model_name added
Actions