Project

General

Profile

Feature #14133

Update to rubocop 0.38.0

Added by Dominic Cleal about 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Update rubocop to 0.38.0 to get rake 11.x compatibility, and revert the rake 10.x pin from #14114.


Related issues

Related to Foreman - Bug #14114: Rake tasks fail under rake 11.x with undefined method `last_comment'Closed2016-03-09
Related to Foreman - Refactor #15364: Disable Style/ClassCheck copClosed2016-06-09
Blocks Packaging - Feature #14809: Build RPMs for Fedora 24Closed2016-04-26

Associated revisions

Revision f0091ac8 (diff)
Added by Dominic Cleal about 6 years ago

fixes #14133 - update to rubocop 0.39.0

Replaces hirb-unicode with the maintained hirb-unicode-steakknife fork,
due to conflicting requirements on unicode-display_width with the older
hirb-unicode and new rubocop.

Rake is unpinned due to the newer rubocop's compatibility with it, and
parser unpinned as the newer rubocop+parser combination works. Custom
rake test tasks have warnings disabled to match Rails behaviour and
prevent lots of output.

Revision 609d3bb8 (diff)
Added by Dominic Cleal about 6 years ago

refs #14133 - use hirb-unicode-steakknife

History

#1 Updated by Dominic Cleal about 6 years ago

A little more complicated, as hirb-unicode (from the console group) has a conflicting dependency with rubocop on unicode-display_width. I've submitted https://github.com/steakknife/hirb-unicode/pull/1 to fix a maintained fork of hirb-unicode (itself now dead) and perhaps it can be switched over, else remove hirb-unicode entirely.

#2 Updated by Dominic Cleal about 6 years ago

  • Related to Bug #14114: Rake tasks fail under rake 11.x with undefined method `last_comment' added

#3 Updated by Dominic Cleal about 6 years ago

#4 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3481 added

#5 Updated by Dominic Cleal about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal about 6 years ago

  • Legacy Backlogs Release (now unused) set to 136

#7 Updated by Marek Hulán almost 6 years ago

Also available in: Atom PDF