Project

General

Profile

Bug #14521

TFTP orchestration fails for OS with iPXE w/o PXELinux associated

Added by Lukas Zapletal almost 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

For a host with OS with iPXE template but no PXELinux template, we still attempt to render PXELinux template which leads to "Failed to generate PXELinux template: undefined method `encoding' for nil:NilClass" orchestration error.

We should give nicer error instead.


Related issues

Related to Foreman - Bug #612: Host#configTemplate does not work as expectedClosed2011-01-25
Related to Foreman - Feature #1294: Build should not require TFTP if using gPXEClosed2011-11-03

Associated revisions

Revision c7bb92a9 (diff)
Added by Lukas Zapletal almost 5 years ago

Fixes #14521 - better error on missing PXELinux template

History

#1 Updated by Lukas Zapletal almost 5 years ago

We already have a check but that does not trigger when there is an iPXE template associated, that is the case:

    if host.provisioning_template({:kind => host.operatingsystem.template_kind}).nil? && host.provisioning_template({:kind => "iPXE"}).nil?
      failure _("No %{template_kind} templates were found for this host, make sure you define at least one in your %{os} settings") %
                { :template_kind => host.operatingsystem.template_kind, :os => host.operatingsystem }
    end

#2 Updated by Lukas Zapletal almost 5 years ago

  • Related to Bug #612: Host#configTemplate does not work as expected added

#3 Updated by Lukas Zapletal almost 5 years ago

  • Related to Feature #1294: Build should not require TFTP if using gPXE added

#4 Updated by Lukas Zapletal almost 5 years ago

  • Subject changed from Queue TFTP orchestration only when there is PXELinux associated to TFTP orchestration fails for OS with iPXE w/o PXELinux associated

#5 Updated by Lukas Zapletal almost 5 years ago

  • Description updated (diff)

#6 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3402 added

#7 Updated by Lukas Zapletal almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#8 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 136

Also available in: Atom PDF