Project

General

Custom queries

Profile

Actions

Bug #14769

closed

UI - show.html.erb error on accessing compute resource details on RHEL6.7

Added by Stephen Benjamin about 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugin integration
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1328878
Description of problem:
There is an error regarding compute_resources/show.html.erb:27

There is no way of displaying/updating a compute resource via UI due to this bug

Occurs only on RHEL6

Version-Release number of selected component (if applicable):
sat 6.2.0 snap 8.2 RHEL6.7

How reproducible:
always

Steps to Reproduce:
1. create any CR using webui
2. recieve the error (happens on accessing CR details)

Actual results:
ISE 500

Expected results:
200 - CR details are displayed

Additional info:

Added by Marek Hulán about 9 years ago

Revision d46b64a2 (diff)

Fixes #14769 - avoid template comments because of deface

After many hours spent on debugging I realized that the issue is that
when action view compiles the template, some lines are concatenated
together just split by ";". This becomes problem when ERB tag contained
commentary symbol #. The reason is that when deface override is applied
it first converts the template to tree using Nokogiri (see Parser.convert).

This returns different results on different versions of underlying library.
I didn't try to compile different versions but with libxml2-2.7.6-20.el6.x86_64 and
libxslt-1.1.26-2.el6_3.1.x86_64 it does not wrap the silent erb tag with
"\n" so as a result, this tag ends up on the same line as previous one.
The same nokogiri but on newer lib versions
(libxml2-2.9.1-5.el7_1.2.x86_64, libxslt-1.1.28-5.el7.x86_64) wrapped
it.

Added by Marek Hulán almost 9 years ago

Revision da9efe51 (diff)

Fixes #14769 - avoid template comments because of deface

After many hours spent on debugging I realized that the issue is that
when action view compiles the template, some lines are concatenated
together just split by ";". This becomes problem when ERB tag contained
commentary symbol #. The reason is that when deface override is applied
it first converts the template to tree using Nokogiri (see Parser.convert).

This returns different results on different versions of underlying library.
I didn't try to compile different versions but with libxml2-2.7.6-20.el6.x86_64 and
libxslt-1.1.26-2.el6_3.1.x86_64 it does not wrap the silent erb tag with
"\n" so as a result, this tag ends up on the same line as previous one.
The same nokogiri but on newer lib versions
(libxml2-2.9.1-5.el7_1.2.x86_64, libxslt-1.1.28-5.el7.x86_64) wrapped
it.

(cherry picked from commit d46b64a2e8debb5298bf58f1941ef3204e401735)

Actions

Also available in: Atom PDF