Project

General

Profile

Actions

Refactor #15847

closed

URL helpers must be used in mailers

Added by Dominic Cleal over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
E-Mail
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

#8797 changed mailers from using *_url helpers to *_path, and relied on Roadie's URL rewriting to change them to full URLs. This works reliably and avoids needing to repeat URL options, but it throws deprecation warnings and will not work in Rails 5.

Running host_mailer_test generates warnings such as:

DEPRECATION WARNING: The method `host_path` cannot be used here as a full URL is required. Use `host_url` instead. (called from app_views_host_mailer_link_to_host_html_erb__4138992061028702271_130918480 at /home/dcleal/code/foreman/foreman/app/views/host_mailer/_link_to_host.html.erb:2)

The change could probably be mostly reverted, and default_url_options used in the mailer to avoid the repetition of URL options.


Related issues 2 (0 open2 closed)

Related to Foreman - Refactor #8797: Separate style from the HTML in emails.ClosedAmir Fefer12/28/2014Actions
Related to Foreman - Refactor #14006: Mailers calling *_path with :only_path => false should use _url helpersClosedDominic Cleal03/02/2016Actions
Actions #1

Updated by Dominic Cleal over 7 years ago

  • Related to Refactor #8797: Separate style from the HTML in emails. added
Actions #2

Updated by Dominic Cleal over 7 years ago

  • Related to Refactor #14006: Mailers calling *_path with :only_path => false should use _url helpers added
Actions #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3677 added
Actions #4

Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 160
Actions

Also available in: Atom PDF