Project

General

Profile

Actions
Copy link

Tracker #17954

closed

Unify roles and permissions across plugins

Added by Ondřej Pražák almost 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Pražák
Category:
-
Target version:
-
% Done:

0%

Difficulty:
Triaged:
Bugzilla link:
1304608
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Each plugin handles permissions and roles differently: some create just permissions and no roles, some create plugin-specific roles. This tracker should monitor the progress of making roles uniform across all plugins.

Expected outcome:
- each plugin has plugin-specific Viewer and Manager roles (see openscap or rex). Additional plugin-specific roles are certainly possible if plugin needs them.
- plugin permissions are added to Manager and Viewer roles provided by core.

Related issues 11 (0 open — 11 closed)

Related to Discovery - Bug #19944: Upgrade fails due to missing override column in filterClosedEric Helms06/06/2017Actions
Blocked by Foreman Remote Execution - Bug #17953: Add remote execution permissions to Viewer and Manager rolesClosedMarek Hulán01/06/2017Actions
Blocked by OpenSCAP - Bug #17952: Add foreman_openscap permissions to Viewer and Manager rolesClosedMarek Hulán01/06/2017Actions
Blocked by Ansible - Bug #17957: Add foreman_ansible permissions to Viewer and Manager rolesClosedMarek Hulán01/06/2017Actions
Blocked by Discovery - Bug #17959: Add foreman_discovery permissions to Manager and Viewer rolesClosedMarek Hulán01/06/2017Actions
Blocked by Docker - Bug #17960: Add foreman_docker permissions to Manager and View rolesClosedMarek Hulán01/06/2017Actions
Blocked by foreman-tasks - Bug #17961: Add foreman-tasks permissions to Manager and Viewer rolesClosedMarek Hulán01/06/2017Actions
Blocked by Katello - Bug #17962: Add Katello's permissions to Manager and and Viewer rolesClosedMarek Hulán01/06/2017Actions
Blocked by Boot disk - Bug #17963: Add foreman_bootdisk permissions to Manager roleClosedMarek Hulán01/06/2017Actions
Blocked by Foreman - Feature #18001: Allow plugins to easily add their permissions to core's Viewer and ManagerClosedOndřej Pražák01/10/2017Actions
Blocked by Foreman - Feature #19039: Lock plugin rolesClosedOndřej Pražák03/27/2017Actions
Actions
Copy link
 #1

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17953: Add remote execution permissions to Viewer and Manager roles added
Actions
Copy link
 #2

Updated by Ondřej Pražák almost 8 years ago

  • Blocks Bug #17952: Add foreman_openscap permissions to Viewer and Manager roles added
Actions
Copy link
 #3

Updated by Ondřej Pražák almost 8 years ago

  • Blocks deleted (Bug #17952: Add foreman_openscap permissions to Viewer and Manager roles)
Actions
Copy link
 #4

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17952: Add foreman_openscap permissions to Viewer and Manager roles added
Actions
Copy link
 #5

Updated by Ondřej Pražák almost 8 years ago

  • Bugzilla link set to 1304608
Actions
Copy link
 #6

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17957: Add foreman_ansible permissions to Viewer and Manager roles added
Actions
Copy link
 #7

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17959: Add foreman_discovery permissions to Manager and Viewer roles added
Actions
Copy link
 #8

Updated by Ondřej Pražák almost 8 years ago

  • Blocks Bug #17960: Add foreman_docker permissions to Manager and View roles added
Actions
Copy link
 #9

Updated by Ondřej Pražák almost 8 years ago

  • Blocks deleted (Bug #17960: Add foreman_docker permissions to Manager and View roles)
Actions
Copy link
 #10

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17960: Add foreman_docker permissions to Manager and View roles added
Actions
Copy link
 #11

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17961: Add foreman-tasks permissions to Manager and Viewer roles added
Actions
Copy link
 #12

Updated by Ondřej Pražák almost 8 years ago

  • Blocks Bug #17962: Add Katello's permissions to Manager and and Viewer roles added
Actions
Copy link
 #13

Updated by Ondřej Pražák almost 8 years ago

  • Blocks deleted (Bug #17962: Add Katello's permissions to Manager and and Viewer roles)
Actions
Copy link
 #14

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17962: Add Katello's permissions to Manager and and Viewer roles added
Actions
Copy link
 #15

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Bug #17963: Add foreman_bootdisk permissions to Manager role added
Actions
Copy link
 #16

Updated by Marek Hulán almost 8 years ago

Ondřej, could we also prevent this happening in future? What if every permission defined by plugin would be automatically assigned to Manager role and if it matches view_.+ it would be also associated to Viewer? Plugins would only defined plugin_manager and plugin_viewer role. Any other suggestions are welcome.

Actions
Copy link
 #17

Updated by Ondřej Pražák almost 8 years ago

  • Blocked by Feature #18001: Allow plugins to easily add their permissions to core's Viewer and Manager added
Actions
Copy link
 #18

Updated by Ondřej Pražák almost 8 years ago

I do not think we can do this completely automatically and there may be cases when we do not want to. But I think #18001 is a reasonable solution.

Actions
Copy link
 #19

Updated by Marek Hulán almost 8 years ago

  • Assignee set to Ondřej Pražák
  • Target version set to 1.11.2
Actions
Copy link
 #20

Updated by Marek Hulán almost 8 years ago

  • Target version changed from 1.11.2 to 1.11.4
Actions
Copy link
 #21

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.11.4 to 1.12.1
Actions
Copy link
 #22

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.12.1 to 1.12.3
Actions
Copy link
 #23

Updated by Ondřej Pražák over 7 years ago

Actions
Copy link
 #24

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.12.3 to 1.13.0
Actions
Copy link
 #25

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.13.0 to 1.13.2
Actions
Copy link
 #26

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.13.2 to 1.13.4
Actions
Copy link
 #27

Updated by Lukas Zapletal over 7 years ago

In Discovery we are planning to lock and reset default discovery plugin roles in a seed script, this is likely a precedent. See discussion at https://github.com/theforeman/foreman_discovery/pull/352

I think the plugin API should do this automatically when roles are being registered (they should be locked).

Actions
Copy link
 #28

Updated by Lukas Zapletal over 7 years ago

  • Related to Bug #19944: Upgrade fails due to missing override column in filter added
Actions
Copy link
 #29

Updated by Marek Hulán over 7 years ago

Lukas Zapletal wrote:

In Discovery we are planning to lock and reset default discovery plugin roles in a seed script, this is likely a precedent. See discussion at https://github.com/theforeman/foreman_discovery/pull/352

I think the plugin API should do this automatically when roles are being registered (they should be locked).

I believe it's tracked by http://projects.theforeman.org/issues/19039, which is ready for testing

Actions
Copy link
 #30

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.13.4 to 1.14.0
Actions
Copy link
 #31

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.14.0 to 1.14.3
Actions
Copy link
 #32

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.14.3 to 1.17.0-RC2
Actions
Copy link
 #33

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.17.0-RC2 to 1.18.0-RC2
Actions
Copy link
 #34

Updated by Marek Hulán about 7 years ago

  • Target version changed from 1.18.0-RC2 to 214
Actions
Copy link
 #35

Updated by Marek Hulán about 7 years ago

  • Status changed from New to Closed

It seems like all related issues have been closed, closing this one.

Actions
Copy link

Also available in: Atom PDF