Project

General

Profile

Actions
Copy link

Bug #20925

closed

katello-change-hostname should check exit codes of shell executions

Added by Evgeni Golov over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Mitsch
Category:
Tooling
Target version:
Katello 3.5.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/Katello/katello-packaging/pull/530
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

currently, k-c-h does a lot `something in shell`, but never verifies the exit code and thus does not know if the execution actually succeeded.

I think it should verify that every execution returned 0 and abort the rename if that is not the case. ideally, the abort is coupled with a rollback, if that is feasible.

Actions
Copy link

Also available in: Atom PDF