Bug #20931
closed
Using host_params in parameters leads to @Safemode doesn't allow to access 'host_params' on #<Safemode::ScopeObject>@
Added by Ivan Necas over 7 years ago.
Updated over 6 years ago.
Description
1. use <%= host_params('blabla') %> inside the host parameters
2. Rendering fails on Safemode doesn't allow to access 'host_params' on #<Safemode::ScopeObject>
- Related to Feature #16740: Host parameters should be available in templates using some macro added
- Difficulty changed from easy to medium
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4835 added
- Translation missing: en.field_release set to 330
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- Related to Bug #23593: function "host_param" in default value of smart class parameter is not allowed anymore. It results in undefined method `host_param' (erb):1:in `parse_string' added
- Triaged set to No
- Fixed in Releases 1.18.2 added
- Fixed in Releases 1.18.0 added
- Fixed in Releases deleted (
1.18.2)
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Added by Ivan Necas over 7 years ago
Fixes #20931 - unify parameters and templates renderer (#4835)
Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that
we want to use in the parameters as well. Also, by the time of writing
the original SafeRenderer, there was no Renderer available.
After doing so, I was hitting issue with recursion, as
`Renderer.host_param` was using `@host.params` while the @host.params
was trying to render the params, that could include the `host_param`
call again, which lead to endless loop. After simplifying the
`HostParams` methods, it is possible to achieve this.
I also noticed that we were rendering only the inherited params and not
the non-inherited once. I've fixed this bug also as part of this patch.
Last but not least, due to the fact that we were using the
host_inherited_params for multiple purposes, we were rendering it also
when showing the host form, which was not even needed.