Bug #21330: http proxy test connection should clear toasts when clicking on it multiple times - Foreman

Bug #21330

http proxy test connection should clear toasts when clicking on it multiple times

Added by Ohad Levy over 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Timo Goebel

Category:

Target version:

1.17.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4922, https://github.com/theforeman/foreman/pull/4921

Fixed in Releases:

Found in Releases:

Nightly

Description

once a user an invalid url or a proxy that is actually is not a proxy, the toast notifications stack up - instead, they should be cleared (as its really not useful to see a "history" of failures in the form).

I would also question the usage of toast notifications to show form errors, I would expect it to show the field error within the form, this will avoid the problem of seeing multiple errors on the same field and not "abuse" the toast notifications.

Related issues

Associated revisions

Revision 60cf8cf2 (diff)
Added by Timo Goebel over 3 years ago

fixes #21330 - http proxies: test connection clears toasts

History

#1 Updated by Ohad Levy over 3 years ago

Related to Feature #12216: allow compute resource connections to use a proxy added

#2 Updated by Ohad Levy over 3 years ago

also note that multiline errors are not displayed correct, for example:
server response:

"status":"failure","message":"Url can't be blank\nUrl is invalid"}

yet the actual message is on the screen is:

Url can't be blank Url is invalid

#3 Updated by The Foreman Bot over 3 years ago

Assignee set to Timo Goebel
Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/4921 added

#4 Updated by Timo Goebel over 3 years ago

Assignee deleted (~~Timo Goebel~~)
Status changed from Ready For Testing to New
Pull request deleted (~~https://github.com/theforeman/foreman/pull/4921~~)