Actions
Refactor #21360
closedRemove legacy code for Ruby <= 2.0 from hammer-cli-foreman
Difficulty:
easy
Triaged:
No
Team Backlog:
Description
Hammer plugin for the Foreman no longer supports ruby 2.0, there's no point of keeping the historical code.
From my search there's following places containing some compatibility code that should be removed:
./hammer/hammer-cli-foreman/lib/hammer_cli_foreman/option_builders.rb: 93 94 def unique(resources) 95: # ruby 1.8 hack - it does not support passing blocks to Array#uniq 96 resources.inject({}) do |h, r| 97 h.update(r.name => r) ./hammer/hammer-cli-foreman/Gemfile: 4 5 gem 'gettext', '>= 3.1.3', '< 4.0.0' 6: if RUBY_VERSION < '2.1.0' 7 gem 'fast_gettext', '< 1.2.0' 8 end
Updated by Tomáš Strachota almost 7 years ago
- Related to Refactor #21359: Remove legacy code for Ruby < 2.0 from hammer-cli added
Updated by Oleh Fedorenko about 6 years ago
- Status changed from New to Assigned
- Assignee set to Oleh Fedorenko
- Triaged set to No
Updated by The Foreman Bot about 6 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli-foreman/pull/372 added
Updated by Tomáš Strachota about 6 years ago
- Subject changed from Remove legacy code for Ruby < 2.0 from hammer-cli-foreman to Remove legacy code for Ruby <= 2.0 from hammer-cli-foreman
Updating the title. The comparison sign didn't correspond with the issue description.
Updated by Oleh Fedorenko about 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset hammer-cli-foreman|0db1790e4bf4cf2d3911eae1ae153f1256abd584.
Updated by Tomer Brisker about 6 years ago
- Fixed in Releases hammer-cli-foreman-0.14.0 added
Actions