Bug #24194

Can't edit http proxy with name containing a dot

Added by Gjermund Jensvoll 10 days ago. Updated about 3 hours ago.

Status:Closed
Priority:Normal
Assignee:Marek Hulán
Category:Network
Target version:1.19.0
Difficulty: Team Backlog:
Triaged:No Fixed in Releases:1.19.0
Bugzilla link: Found in Releases:1.17.0
Pull request:https://github.com/theforeman/foreman/pull/5825

Description

Description

Editing a http proxy with a dot in the name (not URL) results in a "The page you were looking for doesn't exist."

How reproducible:
Every time

Steps to Reproduce:
  1. Go to https://katello.example.com/http_proxies
  2. Make a new HTTP proxy
  3. Name it with a fqdn in the Name field (example: proxy.example.com)
  4. Fill out URL and press Submit
  5. Click on proxy.example.com

Actual results:

The page you were looking for doesn't exist.
You may have mistyped the address or the page may have moved.
If you are the application owner check the logs for more information.

Expected results:
Should be able to edit the proxy

Additional info:
production.log shows:

2018-07-09T08:15:56 4294c2b5 [app] [I] Started GET "/http_proxies/proxy.example.com/edit" for 192.168.0.100 at 2018-07-09 08:15:56 +0200
2018-07-09T08:15:56 4294c2b5 [app] [F]   
2018-07-09T08:15:56 4294c2b5 [app] [F] ActionController::RoutingError (No route matches [GET] "/http_proxies/proxy.example.com/edit"):
2018-07-09T08:15:56 4294c2b5 [app] [F]   
2018-07-09T08:15:56 4294c2b5 [app] [F] lib/middleware/tagged_logging.rb:18:in `call'
 | katello (3.6.0) lib/katello/prevent_json_parsing.rb:12:in `call'

Associated revisions

Revision ab289f90
Added by Marek Hulán 7 days ago

Fixes #24194 - support dots in name for http proxies

History

#1 Updated by Justin Sherrill 8 days ago

  • Category deleted (Web UI)
  • Project changed from Katello to Foreman

Moving to foreman, as this feature lives there.

#2 Updated by The Foreman Bot 7 days ago

  • Assignee set to Marek Hulán
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5825 added

#3 Updated by Tomer Brisker 7 days ago

  • Target version set to 1.19.0
  • Found in Releases 1.17.0 added
  • Fixed in Releases 1.19.0 added

#4 Updated by Marek Hulán 7 days ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#5 Updated by Ewoud Kohl van Wijngaarden about 3 hours ago

  • Category set to Network

Also available in: Atom PDF