Project

General

Profile

Bug #25180

Providing custom=false to products controller does not filter out custom products

Added by Walden Raines over 2 years ago. Updated about 2 years ago.


Description

If I provide custom=false I still get custom products, see: https://github.com/Katello/katello/blob/b7dc5d44d9d2af3b64a0c063a67f1e810be891cb/app/controllers/katello/api/v2/products_controller.rb#L50

Steps to Reproduce

  • Access products API with custom=false (or any other value for that matter) - /katello/api/v2/organizations/1/products/?custom=false
  • Notice that only custom products are returned regardless of the value supplied to custom

Associated revisions

Revision 22220f49 (diff)
Added by John Mitsch about 2 years ago

Fixes #25180 - Products index custom param fix

  • Fixes #25180 - Products index custom param fix

The custom param for the products controller wasn't working
before, this commit changes it to be cast as a bool. It also
adds the param to the Red hat repositories page product filter.

To test, you can fill and organizaiton with custom and RH products,
then use the API to ensure the `custom` param works.

Then, check the RH repos page 'filter by product' dropdown
no longer returns custom products

Revision 6c02e861 (diff)
Added by John Mitsch about 2 years ago

Refs #25180 - Fix product list on RH repos

Revision 53e88d8a (diff)
Added by John Mitsch about 2 years ago

Fixes #25901 - Display arch for RHEL8 repos (#7938)

  • Fixes #25901 - Display arch for RHEL8 repos

This commit adds an additional option for showing arch in repository
sets. This is derived from the CDN path and the actual
substitutions. This field is derived in from the path in the UI to show
the arch for the repo set, but it is not passed back for
the actual CDN call.

To test, ensure you can enable RHEL8 and RHEL8 beta
repositories

This reverts commit 161c363cdcdb9fbf7c22bf1bd278717d25fa6b43.

This reverts commit 091015e9b30dfce041d6173d63fc61ee55c5fbe1.

  • Refs #25180 - Add logic to front end
  • Refs #25180 - add tests and small fixes

This squashed commit reversed a previous change in favor
of moving the logic to the UI

History

#1 Updated by Walden Raines over 2 years ago

  • Description updated (diff)

#2 Updated by Michael Johnson over 2 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.10.0
  • Assignee set to John Mitsch

#3 Updated by Andrew Kofink over 2 years ago

  • Found in Releases Katello 3.4.0, Katello 3.4.1, Katello 3.4.2, Katello 3.4.3, Katello 3.4.4, Katello 3.4.5, Katello 3.4.6, Katello 3.5.0, Katello 3.5.1, Katello 3.5.2, Katello 3.5.3, Katello 3.6.0, Katello 3.6.1, Katello 3.7.0, Katello 3.7.1, Katello 3.8.1, Katello 3.8.2, Katello 3.9.0, Katello 3.9.1 added

This behavior is also present in releases as early as 3.4

#4 Updated by Christine Fouant over 2 years ago

  • Target version changed from Katello 3.10.0 to Katello 3.11.0

#5 Updated by Jonathon Turel about 2 years ago

  • Target version changed from Katello 3.11.0 to Katello 3.11.1
  • Team Backlog Brad added

#6 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7928 added

#7 Updated by John Mitsch about 2 years ago

  • Bugzilla link set to 1667129

#8 Updated by John Mitsch about 2 years ago

  • Status changed from Ready For Testing to Closed

#9 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/Katello/katello/pull/7936 added

#10 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/Katello/katello/pull/7938 added

Also available in: Atom PDF