Actions
Bug #27559
closed
"Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
JavaScript stack
Target version:
-
Description
Satellite 6.6 have login button like this:
<input type="submit" name="commit" value="Log In" class="btn btn-primary" data-disable-with="Log In">
New form have:
<button type="submit" disabled="" class="login-pf-submit-button btn btn-lg btn-primary btn-block">Log In</button>
QE UI automation is using that:
Would it be possible to put "name=" back or add "id=" (generally, QE would like to have ID on every functional form component)?
Updated by Jan Hutař over 5 years ago
- Subject changed from "Log in" button on login screen used to have 'name="commit"` and new version of login for do not have it to "Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it
Updated by Marek Hulán over 5 years ago
That's since it's no longer rendered using rails helpers. Would some unique id help or is the name important attribute for the automation? This was probably introduced by https://github.com/theforeman/foreman/pull/6234
Updated by Marek Hulán over 5 years ago
- Related to Feature #24990: Move LoginPage into a React component using patternfly-react LoginPage component. added
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/6971 added
Updated by Ron Lavi over 5 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 8fe3f5d4a9c5a6b774a4e5060d574b18d28c04be.
Updated by
Actions