Project

General

Profile

Actions
Copy link

Bug #28269

closed

Remove translation from column table function

Added by Jeremy Lenz almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Maria Agaphontzev
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7176, https://github.com/theforeman/foreman/pull/7154
Fixed in Releases:
2.0.0
Found in Releases:
Red Hat JIRA:

Description

The column should not do that because we have a script that searches for the __ in order to extract all the strings needs to be translated and upload them to the translation service.
All '__' instances should be hard coded strings and not variables so the script will only send strings to translate (and not variable name)
https://github.com/theforeman/foreman/blob/7f113cb4b781283ea7b50ee78d980414dd3bc741/webpack/assets/javascripts/react_app/components/common/table/schemaHelpers/column.js#L28

Actions
Copy link
 #1

Updated by Maria Agaphontzev almost 5 years ago

  • Category set to Web Interface
  • Assignee set to Maria Agaphontzev
Actions
Copy link
 #2

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7176 added
Actions
Copy link
 #3

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases 2.0.0 added
Actions
Copy link
 #4

Updated by Maria Agaphontzev almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7154 added
Actions
Copy link

Also available in: Atom PDF